Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(WEBRTC-478): hide telnyxIDs and clientState on public docs #172

Merged
merged 3 commits into from
Apr 13, 2021
Merged

feat(WEBRTC-478): hide telnyxIDs and clientState on public docs #172

merged 3 commits into from
Apr 13, 2021

Conversation

DeividVeloso
Copy link
Contributor

  • hide telnyxIDs and clientState on public docs, these features are in WIP.

📝 To Do

  • All linters pass
  • All tests pass
  • Change documentation based on my changes

✋ Manual testing

  1. Navigate into packages/js
  2. Run npm i && npm run docs
  3. See the generate docs on js/docs
  4. The clientState and telnyxIDs should not be included on MD files.

🦊 Browser testing

Desktop

  • Edge (latest)
  • Chrome
  • Firefox
  • Safari

📸 Screenshots

Description Screenshot
Desktop
usage.gif

@DeividVeloso DeividVeloso merged commit 7cefa76 into main Apr 13, 2021
@DeividVeloso DeividVeloso deleted the WEBRTC-478 branch April 13, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arghav arghav arghav approved these changes

@hugooliveirad hugooliveirad Awaiting requested review from hugooliveirad

@SuaYoo SuaYoo Awaiting requested review from SuaYoo

@paulgkramer paulgkramer Awaiting requested review from paulgkramer

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DeividVeloso @arghav