Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(WEBRTC-384): fix utilities examples from storybook #150

Merged
merged 2 commits into from
Mar 1, 2021
Merged

fix(WEBRTC-384): fix utilities examples from storybook #150

merged 2 commits into from
Mar 1, 2021

Conversation

DeividVeloso
Copy link
Contributor

  • fix utilities examples from storybook

📝 To Do

  • All linters pass
  • All tests pass
  • Change documentation based on my changes

✋ Manual testing

  1. Navigate into packages/js/exmples/react-audio-widgets
  2. Run npm i && npm run storybook
  3. Access http://localhost:6006/?path=/story/utilities--example
  4. Click in some buttons to see the results.

🦊 Browser testing

Desktop

  • Edge (latest)
  • Chrome
  • Firefox
  • Safari

📸 Screenshots

Description Screenshot
Desktop image

@DeividVeloso DeividVeloso merged commit d159bd3 into main Mar 1, 2021
@DeividVeloso DeividVeloso deleted the WEBRTC-384 branch March 1, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugooliveirad hugooliveirad hugooliveirad approved these changes

@SuaYoo SuaYoo Awaiting requested review from SuaYoo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DeividVeloso @hugooliveirad