Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(WERTC-342): update storybook to improve the build time #144

Merged
merged 11 commits into from
Feb 12, 2021

Conversation

DeividVeloso
Copy link
Contributor

@DeividVeloso DeividVeloso commented Jan 29, 2021

  • add corejs that is used to polifyll the latest ECMAScript standard.
  • update storybook to improve the build time

Notes

I'm suspicious on Storybook and TypeDocs from @telnyx/webrtc.
I think the typedocs use many methods to handle array to generate de documents.

I didn't find any official, but adding the corejs it solve the problem with Storybook and Telnyx/WebRTC

CoreJS
Additionally, CoreJS is packaged with the CoreDoc tool, which works similarly to JavaDoc to generate API specifications from embedded comments in JavaScript code. It features the ability to parse classes defined using CoreJS' Core.extend() architecture.

📝 To Do

  • All linters pass
  • All tests pass
  • Change documentation based on my changes

✋ Manual testing

  1. Remove every node_modules folder in all subfolders.
  2. Run npm i on root
  3. Run npm i on packages/js
  4. Run npm i on packages/js/examples/react-audio-widgets and run npm run setup
  5. Navigate to packages/js/examples/react-audio-widgets and run npm run storybook
  6. You shouldn't get any error.

🦊 Browser testing

Desktop

  • Edge (latest)
  • Chrome
  • Firefox
  • Safari

📸 Screenshots

Error

image (8)

Success

image

Tests

image

@DeividVeloso DeividVeloso requested a review from SuaYoo January 29, 2021 18:53
@DeividVeloso DeividVeloso marked this pull request as ready for review January 29, 2021 18:53
@DeividVeloso DeividVeloso force-pushed the WEBRTC-342-storybook-and-npm-link branch from d579076 to 153562e Compare January 29, 2021 19:59
@DeividVeloso DeividVeloso merged commit ead9434 into main Feb 12, 2021
@DeividVeloso DeividVeloso deleted the WEBRTC-342-storybook-and-npm-link branch February 12, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants