chore(WEBRTC-366): testing workflow #143
Conversation
There was a problem hiding this comment.
It looks like the changes from https://github.com/team-telnyx/webrtc/pull/142/files made it into this PR as well, can you remove those commits or change the base branch?
| browser: edge | ||
| headless: true | ||
| env: STORYBOOK_USERNAME=${{ secrets.NPM_CI_STORYBOOK_USERNAME }},STORYBOOK_PASSWORD=${{ secrets.NPM_CI_STORYBOOK_PASSWORD }},STORYBOOK_DESTINATION=${{ secrets.NPM_CI_STORYBOOK_DESTINATION }} | ||
| build: |
There was a problem hiding this comment.
This seems like it could be consolidated with unit-tests
There was a problem hiding this comment.
I prefer to keep separated, I did 3 steps:
- unit-test
- e2e
- build/release
| .env | ||
| yarn.lock |
There was a problem hiding this comment.
Why add the lockfile to gitignore? Also, it looks like the file was committed to this PR
There was a problem hiding this comment.
When we use the command npm ci we need to remove the yarn.lock, because the GITHUB/ACTIONS complain about that.
There was a problem hiding this comment.
Run cypress-io/github-action@v2
/usr/bin/yarn --frozen-lockfile
yarn install v1.22.5
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] Resolving packages...
warning cypress > @cypress/request > [email protected]: this library is no longer supported
error Your lockfile needs to be updated, but yarn was run with `--frozen-lockfile`.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Error: The process '/usr/bin/yarn' failed with exit code 1
`
``
There was a problem hiding this comment.
I think they meant you should remove package-lock.json file instead, as it could potentially be used instead of yarn.lock.
webrtc-test-release.ymlto run e2e tests📝 To Do
✋ Manual testing
Actionstab and choose thewebrtc-test-release.yml🦊 Browser testing
Desktop