-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(WEBRTC-317): add methods to check webrtc compatibility and list the supported browser #135
Conversation
dd3c13d
to
7ff94ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General question, do we have internal documentation on how we determine browser support? I'm curious as to why we've defined a custom list of supported browsers. Any specific reason not to use something like https://www.npmjs.com/package/detectrtc?
Co-authored-by: Sua Yoo <[email protected]>
Co-authored-by: Sua Yoo <[email protected]>
Co-authored-by: Sua Yoo <[email protected]>
Co-authored-by: Sua Yoo <[email protected]>
Co-authored-by: Sua Yoo <[email protected]>
Co-authored-by: Sua Yoo <[email protected]>
Co-authored-by: Sua Yoo <[email protected]>
Co-authored-by: Sua Yoo <[email protected]>
Co-authored-by: Sua Yoo <[email protected]>
Co-authored-by: Sua Yoo <[email protected]>
Co-authored-by: Sua Yoo <[email protected]>
1 - about browser support, I defined those major browsers that I've tested and worked. For example Firefox we are supporting partially because of the 2 - about detectrtc I didn't use any third library to avoid create dependency for small things like check if the browser has RTCPerrConnection implemented. I'm open to change if you think it is better, what do you think? |
Co-authored-by: Sua Yoo <[email protected]>
|
||
```js | ||
const info = TelnyxRTC.webRTCInfo(); | ||
const isWebRTCSupported = info.supportWebRTC; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
info.supportsWebRTC
| | Chrome | Firefox | Safari | Edge | | ||
|---------|--------|---------|--------|------| | ||
| Android | [-] | [-] | [ ] | [ ] | | ||
| iOS | [ ] | [ ] | [-] | [ ] | | ||
| Linux | [x] | [-] | [ ] | [ ] | | ||
| MacOS | [x] | [-] | [x] | [-] | | ||
| Windows | [x] | [-] | [ ] | [-] | | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to use
--
instead of [ ]
for browsers that do not exist (Safari on Linux)
📝 To Do
✋ Manual testing
packages/js
and runnpm run build
js/examples/react-audio
and runnpm setup
TelnyxRTC.webRTCInfo()
to know if the browser supports TelnyxRTCTelnyxRTC.webRTCSupportedBrowserList()
to know the supported browserspackages/js
andnpm run test
you should get all green.packages/js
andnpm run docs
you should see the new methods documented onTelnyxRTC.MD
🦊 Browser testing
Desktop
📸 Screenshots
Supported browser result
Not supported browser