Update webrtc package imports #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuaYoo
commented
Jan 15, 2021
Comment on lines
-16
to
-17
| remoteCallerName: '', | ||
| remoteCallerNumber: '', |
There was a problem hiding this comment.
We don't currently document these options, can you confirm that we don't support them @DeividVeloso ?
There was a problem hiding this comment.
I'm not sure, but I think these comes from FreeSwitch
DeividVeloso
approved these changes
Jan 15, 2021
Comment on lines
-16
to
-17
| remoteCallerName: '', | ||
| remoteCallerNumber: '', |
There was a problem hiding this comment.
I'm not sure, but I think these comes from FreeSwitch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@telnyx/webrtcfrom peer dependency to dependencies for easier version managementThis will need to be released with a major version bump to prevent versioning issues for end users.
📝 To Do
✋ Manual testing
packages/react-client: Runnpm installandnpm run buildpackages/react-client/example: Runnpm install --no-package-lockpackages/react-client/example: Runnpm startand make a call. Verify app functions as expected🦊 Browser testing
Desktop