Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(WEBRTC-266-267): add typedoc on local and remote stream properties #113

Merged
merged 6 commits into from
Dec 15, 2020

Conversation

DeividVeloso
Copy link
Contributor

  • add typedoc on local and remote stream properties

πŸ“ To Do

  • All linters pass
  • All tests pass
  • Change documentation based on my changes

βœ‹ Manual testing

  1. Internal documentation

Comment on lines 148 to 150
* ```js
* call.localStream();
* ```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add an example of how to get this into a video or audio element with srcObject.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Comment on lines 163 to 165
* ```js
* call.remoteStream();
* ```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add an example of how to get this into a video or audio element with srcObject.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@DeividVeloso DeividVeloso merged commit 22a3627 into main Dec 15, 2020
@DeividVeloso DeividVeloso deleted the WEBRTC-266-267 branch December 15, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants