Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline JS README #107

Merged
merged 8 commits into from
Dec 16, 2020
Merged

Streamline JS README #107

merged 8 commits into from
Dec 16, 2020

Conversation

SuaYoo
Copy link
Contributor

@SuaYoo SuaYoo commented Dec 12, 2020

Streamlines the @telnyx/webrtc README by cross-linking with examples in docs, to reduce the amount of duplicated (and erroneous) example code.

Side by side comparison: Current README | Proposed README

@SuaYoo SuaYoo marked this pull request as ready for review December 12, 2020 00:32
@SuaYoo SuaYoo mentioned this pull request Dec 12, 2020
Copy link
Contributor

@DeividVeloso DeividVeloso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put some MINOR comments

Copy link
Contributor

@hugooliveirad hugooliveirad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, nothing major. Great job making this simpler

@SuaYoo SuaYoo merged commit 66eb746 into main Dec 16, 2020
@SuaYoo SuaYoo deleted the Update_js_readme branch December 16, 2020 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants