feat(WEBRTC-52): migrate module verto to telnyx_rtc #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.options.onWSLogin(this, true); | ||
| } | ||
| this.authing = false; | ||
| // console.log('logged in'); |
There was a problem hiding this comment.
@DeividVeloso console.log
src/Modules/TelnyxRTC/Verto.ts
Outdated
| } | ||
| }, | ||
| this.authing = false; | ||
| // console.log( |
jonathan-telnyx
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove verto module and add telnyx_rtc by default.
Remove host webrtc2 and add rtc and rtcdev.
Remove port 14939 and set by default 14938 to use in dev and prod.
📝 To Do
✋ Manual testing
🦊 Browser testing
Desktop