[WEBRTC-690][ENGDESK-11170] Push Notification investigation enhancements + IceCandidate Bug Fix #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebRTC-690 - Push Notification investigation.
This PR fixes the autologin mechanism by storing the environment used after a successful login.
There is also another socket listener method that is used to set our sessionID earlier, this makes it possible to build a call before the login is successful which is useful for the upcoming Push Notification release
We no longer send video media constraints on the WebRTC SDK
We now wait 300 ms before sending our invite, this means that we have time to gather more (most often all), ice candidates, before sending our invitation. This hopefully fixes a customer issue where IPv6 was the only candidate available, which is not supported
👴 👶 Behaviors
Before changes
Environment not remembered for autologin
Session ID being set on successful login
Sending video media constraints with the invitation and answer SDPs
Sending invite as soon as first ice candidate obtained
After changes
Environment remembered via shared preferences
The session ID is now set as soon as a login is attempted, rather than after it was successful
No video media constraints in SDPs
We now leave 300 ms to collect ice candidates before sending the invite