[WEBRTC-1618] Generate random UUID when params are missing #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebRTC-1618 - onRingingReceived missing leg and session ID fix
This PR adds random UUID for the onRingingReceived Call message when the telnyx_session_id and telnyx_leg_id are missing from the jsonObject.
👴 👶 Behaviors
Before changes
If these params are missing (rare, uncertain of cause. Backend related), the application would crash
After changes
Instead of not handling the missing params, we now generate a random UUID. The call still works with these random values.
✋ Manual testing