Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check identity for default_cache_value #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

check identity for default_cache_value #19

wants to merge 1 commit into from

Conversation

nikitka
Copy link

@nikitka nikitka commented Mar 16, 2017

We should use object identity instead of equality because some libraries (like pandas) returns object that overrides __eq__ and returns non-boolean result.

@coveralls
Copy link

coveralls commented Mar 16, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 86.802% when pulling 8def82f on nikitka:master into 14d1484 on tvavrys:master.

@tvavrys
Copy link

tvavrys commented May 22, 2018

I'm hesitating with this. See https://dbader.org/blog/difference-between-is-and-equals-in-python Any thoughts?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikitka @coveralls @tvavrys