Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy connection and healthcheck #183

Merged
merged 16 commits into from
Jan 13, 2022
Merged

Proxy connection and healthcheck #183

merged 16 commits into from
Jan 13, 2022

Conversation

Janaka-Steph
Copy link
Collaborator

@Janaka-Steph Janaka-Steph commented Dec 21, 2021

Handle proxy connection and health check.
healthCheck is called in useExponentialInterval (fast at startup then every 4 secs).
Fix market selection error by fetching asset data from Esplora and determining market based on ticker rather than asset_id.

It closes #108
It closes #122
It closes #176
It closes #177
It closes #181

Known issue:

Please review @tiero @altafan

@tiero
Copy link
Contributor

tiero commented Dec 21, 2021

utACK

@altafan
Copy link
Contributor

altafan commented Dec 22, 2021

@Janaka-Steph I always need to reload the app after pairing with an initialized daemon to see balances, markets, etc correctly.

From the console, it seems like the dashboard tries to call the grpc methods while connecting. It should either wait for the proxy to be connected or retry all the failing grpc calls.

@Janaka-Steph
Copy link
Collaborator Author

Janaka-Steph commented Dec 22, 2021

@Janaka-Steph I always need to reload the app after pairing with an initialized daemon to see balances, markets, etc correctly.

From the console, it seems like the dashboard tries to call the grpc methods while connecting. It should either wait for the proxy to be connected or retry all the failing grpc calls.

@altafan
Last commit should fix this. Still need to shorten the useInterval loop (fast at startup then 5sec) to speedup the refresh.

@altafan
Copy link
Contributor

altafan commented Dec 22, 2021

Yes, it's fixed 👍

@altafan
Copy link
Contributor

altafan commented Jan 10, 2022

@Janaka-Steph I tested after the last commits:

  • the red/yellow/green button signaling the status of the proxy has disappeared if starting the app with yarn tauri:dev
  • After pairing the dashboard with an initialized daemon, if I quit the tauri app and then restart again with yarn tauri:dev the error modal with message Service Unavailable - Service is not available or credentials are wrong, please retry. is shown. It's enough to reload the app to make it work correctly.

Screenshot 2022-01-10 at 14 55 45

  • Dunno if this is a known issue already, but on regtest I'm not able to withdraw funds from a market. I always get the message market selection error with any valid amount. Also not sure the select input on the left looks good.

Screenshot 2022-01-10 at 14 39 12

@Janaka-Steph Janaka-Steph merged commit 368bdad into master Jan 13, 2022
@Janaka-Steph Janaka-Steph deleted the healthcheck branch January 13, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment