Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ignoreUrls option #38

Closed
wants to merge 1 commit into from
Closed

Conversation

nschonni
Copy link
Contributor

Completely eyeballed and not tested/run. I just wanted to through this up for discussion since I noticed you added the concept of a config file.

@timmkrause
Copy link

Cool! Was thinking to add this as well. Can you write a test for it?

@timmkrause
Copy link

timmkrause commented May 16, 2018

The following came additionally to my mind: Maybe it would make sense to rename "ignoreUrls" to "ignorePatterns" (or something) and make it regular expressions? I also have the requirement to ignore some relative markdown links. That way it would be more flexible. What do you think?

@nschonni
Copy link
Contributor Author

Yeah, I think strings or regex makes a bunch of sense to be able to filter them out. I just did this as a quick POC to see if it made sense.
The other part I was thinking of is if the skipped links should show up in the UI somehow. Maybe a yellow [?] instead of the check/X for the pass/failed links

@timmkrause
Copy link

timmkrause commented May 17, 2018

The other part I was thinking of is if the skipped links should show up in the UI somehow. Maybe a yellow [?] instead of the check/X for the pass/failed links

Good one. Personally I would prefer that the ignore check happens within link-check (so the ignore options data needs to flow into it) and return an appropriate result of ignored so that the evaluation (and display) can be done in a consistent way by resolving the status appropriately via statusLabels[result.status] in markdown-link-check.runMarkdownLinkCheck().

@tcort What is your opinion?

@timmkrause
Copy link

What do you think about #41? I have implemented it using regular expressions to gain more flexibility and made it visible in the CLI.

@nschonni
Copy link
Contributor Author

Closing this in favour of #41 since it is more fleshed out, and the regex method is a better way to go

@nschonni nschonni closed this May 23, 2018
@nschonni nschonni deleted the ignoreUrls branch May 23, 2018 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants