Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem of deleting/renaming on the win platform #53

Merged
merged 1 commit into from
Aug 22, 2020

Conversation

binsee
Copy link
Contributor

@binsee binsee commented Aug 21, 2020

When deleting or renaming files on the win platform, the nodes cannot be operated correctly.

The way of handling file names in parseFile() was changed before, but the same process is not performed when deleting and renaming files.

Reference

export const parseFile = async (graph: Graph, filePath: string) => {
filePath = path.normalize(filePath);

Therefore, the node that should be removed still exists.

@tchayen
Copy link
Owner

tchayen commented Aug 22, 2020

Thank you so much!

@tchayen tchayen merged commit 7485d9f into tchayen:master Aug 22, 2020
@binsee binsee deleted the fix-del-and-rename-bug branch August 22, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants