Epic error rework #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was just for quick and dirty development, it can be removed now. Add todos in places I'm not 100% sure about - requires more BIP reading.
Add a `CombineError` to the `v0` module, requires moving the `InconsistentKeySources` error to the crate level `error` module.
We currently use an `io::Error` when deserialization encounters a slice with not enough data. This is unnecessary, we can use a custom variant.
In-memory readers do not error, we do not need to return this unreachable error.
The `unsigned_tx_checks()` function can have its own error type, while this is not a big win it helps isolate the v0 stuff within the `crate::Error` type and make it obvious it needs improving.
Group the error variants that relate only to PSBT v0. Refactor only, no logic change.
This function only errors if the unsigned tx checks fail, return that specific error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spilt the general crate error into specific errors. This PR is basically un-reviewable because its so massive.