Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase against on Element X develop #11

Closed
wants to merge 517 commits into from
Closed

Rebase against on Element X develop #11

wants to merge 517 commits into from

Conversation

yostyle
Copy link

@yostyle yostyle commented Oct 7, 2024

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

bmarty and others added 30 commits September 19, 2024 10:02
@bmarty
Merge pull request #3450 from element-hq/feature/bma/improveCoverageM…
c510d12 
…etrics

Improve code coverage metrics
@bmarty
Adding fastlane file for version 0.6.3
7eac45e
@bmarty
Merge branch 'release/0.6.3' into main
cec945c
@bmarty
Merge tag 'v0.6.3' into develop
58ea2c7 
tag
@bmarty
version++
1dbd7df
@bmarty
Changelog for version 0.6.3
929cefa
@bmarty
Change ElementBot mail to [email protected]
197fe9b
@bmarty
Add first test on RustMatrixClient
c8c7931
@bmarty
Change signature of RustMatrixClient, val are not always necessary.
96a2828
@bmarty
Create a factory function for RustMatrixClient
40e8b56
@bmarty
Fix compilation issue
3f35bf7
@bmarty
Add test skeleton for RustMatrixClientFactory and RustMatrixAuthentic…
0e90e57 
…ationService
@bmarty
Add test on RustClientSessionDelegate
86844e0
@bmarty
Cleanup
77e6a94
@bmarty
Add test on RustRoomDirectoryService
47df0d1
@ganfra
Merge branch 'develop' into renovate/accompanist
025f48a
@bmarty
Merge pull request #3497 from element-hq/feature/bma/changeElementBot…
9571261 
…Mail

Change ElementBot mail to [email protected]
@bmarty
Inject constructor
a7d4bab
@bmarty
Add test on RustRoomDirectoryList
d1be434
@bmarty
Add test on RoomDirectorySearchProcessor
b67c428 
Give the responsibility to the RoomDirectorySearchProcessor to create the `MutableSharedFlow` since it requires a replayCache to work properly.
@bmarty
Add test on RoomListFactory
1fd1f01
@bmarty
Add test on RustRoomListService
de7d93e
@bmarty
Cleanup constructor and avoid creating many mapper instances
8127aa6
@bmarty
Fix test
e117b74
@bmarty
Add unit test on HomeserverLoginDetails.map()
bfaa9f8
@bmarty
Add unit test on ExternalSession.toSessionData
145c40d
@bmarty
Add unit test on RustNotificationService
6fa585f 
And fix mapping error.
@bmarty
Add test on RustNotificationSettingsService
f209eb2
@bmarty
Add test on AccountManagementAction.toRustAction()
8439c10
@bmarty
Add test on RustPushersService
98cfa25
bmarty and others added 27 commits October 7, 2024 15:30
@bmarty
Merge pull request #3609 from element-hq/feature/bma/slidingSyncCheck
de6b34d 
Remove supportSlidingSync boolean.
@bmarty
Ensure the CI compile and execute all the unit tests.
60dd4db
@bmarty
Revert "Ensure the CI compile and execute all the unit tests."
ce811bd 
This reverts commit 60dd4db.
@bmarty
Ensure the CI compile and execute all the unit tests.
76fd931
@bmarty
Fix compilation issue in RustMatrixClientFactoryTest...
9e32463
@bmarty
... and fix the test.
23c0dc1
@renovate @jmartinesp
fix(deps): update dependency com.squareup:kotlinpoet-ksp to v1.18.1 (#…
b1f5480 
…3580)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jorge Martin Espinosa <[email protected]>
@bmarty
Merge pull request #3617 from element-hq/feature/testOnCi
dd60eaf 
Ensure the CI compile and execute all the unit tests.
@bmarty
Konsist: Ensure that unit tests are detected
f2ca3c3
@bmarty
Konsist: Ensure that Presenter do not depend on other presenters.
ac481a5
@bmarty
Remove dependencies to other presenters from RootPresenter
f99081f
@bmarty
Remove dependencies to other presenters from DeveloperSettingsPresenter
e9e4963
@bmarty
Remove dependencies to other presenters from PreferencesRootPresenter.
a100676 
Also do some renaming since DirectLogoutPresenter interface can be removed.
@bmarty
Remove dependencies to other presenters to FullScreenIntentPermission…
241dae1 
…sPresenter.

Also do some renaming since FullScreenIntentPermissionsPresenter interface can be removed.
@bmarty
Remove dependencies to other presenters to AnalyticsPreferencesPresen…
8db9c22 
…ter.
@bmarty
Remove dependencies to other presenters to ChangeServerPresenter.
9772535
@bmarty
Remove dependencies to other presenters to LeaveRoomPresenter.
0a7de7c
@bmarty
Remove dependencies to other presenters to RoomMembersModerationPrese…
2e5450c 
…nter.

Move canDisplayModerationActions from presenter API to the state it emits.
@bmarty
Remove dependencies to other presenters in MessagesPresenter.
d744e07
@bmarty
Cleanup
6cfebc1
@bmarty
Fix compilation issue on minimal app.
25e5fde
@bmarty
Remove FakeLeaveRoomPresenter
792bc25
@bmarty
Use backgroundScope
b60d7ba
@bmarty
Remove unused import.
d390b4f
@renovate
fix(deps): update dependency org.matrix.rustcomponents:sdk-android to…
0c96dee 
… v0.2.52
@bmarty
Merge pull request #3618 from element-hq/feature/bma/injectPresenter
51ee5bf 
Ensure that `Presenter`s do not depend on other presenters.
@bmarty
Merge pull request #3619 from element-hq/renovate/org.matrix.rustcomp…
409564a 
…onents-sdk-android-0.x

Update dependency org.matrix.rustcomponents:sdk-android to v0.2.52
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • Your branch should be based on origin/develop, at least when it was created.
  • The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

@yostyle yostyle closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yostyle @bmarty @ganfra @ElementBot @jmartinesp @BillCarsonFr @frebib