Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix password update management in Tchap Settings screen #712

Merged
merged 3 commits into from
Jan 23, 2023
Merged

Fix password update management in Tchap Settings screen #712

merged 3 commits into from
Jan 23, 2023

Conversation

phloux
Copy link

@phloux phloux commented Jan 20, 2023

@phloux phloux marked this pull request as ready for review January 20, 2023 16:22
@NicolasBuquet
Copy link
Contributor

Property changePasswordAlertPresenter is no more used and can be deleted.

// Tchap: Customize Password change
#ifdef SECURE_BACKUP
@property (nonatomic, strong) ChangePasswordAlertPresenter *changePasswordAlertPresenter;
#endif

@phloux
Copy link
Author

phloux commented Jan 23, 2023

Property changePasswordAlertPresenter is no more used and can be deleted.

// Tchap: Customize Password change
#ifdef SECURE_BACKUP
@property (nonatomic, strong) ChangePasswordAlertPresenter *changePasswordAlertPresenter;
#endif

Oh yes, I forgot to remove it.
I will update the PR.

@phloux phloux merged commit ed8eb46 into develop Jan 23, 2023
@phloux phloux deleted the phlpro/710-change-password branch January 23, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasBuquet NicolasBuquet NicolasBuquet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phloux @NicolasBuquet