Hide menu for invited users

[phloux]

#701 (comment)

[giomfo]

@phlniji your change is ok
but I did some tests, and I discovered a bug:

• the plus button is not correctly updated after a new login :
  • If I log in with an agent account after log out an external account the (+) is missing
  • if I log in with an external account after logging out an agent account: the (+) is visible with the 3 options

I think you need to update this (+) button on userSessionsServiceDidAddUserSession like you already did for the top left button

[phloux]

@phlniji your change is ok but I did some tests, and I discovered a bug:

• the plus button is not correctly updated after a new login :

  • If I log in with an agent account after log out an external account the (+) is missing
  • if I log in with an external account after logging out an agent account: the (+) is visible with the 3 options

I think you need to update this (+) button on userSessionsServiceDidAddUserSession like you already did for the top left button

We already observe the UserSessionsService.didAddUserSession notification.
So I think the notification registration has been done too late, or there is an issue with the guard isViewLoaded from updateUI method.
I will check this.

[giomfo]

LGTM
As we discussed it in direct, I let you have a look on the use case highlighted above. Because the probability for an actual user to observe it is very low, we will manage it only if a simple fix is possible

[giomfo]

LGTM