Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Project Cleaning] Remove the compilation flags for the enabled features #646

Merged
merged 1 commit into from
Aug 2, 2022
Merged

[Project Cleaning] Remove the compilation flags for the enabled features #646

merged 1 commit into from
Aug 2, 2022

Conversation

phloux
Copy link

@phloux phloux commented Aug 1, 2022

@phloux phloux marked this pull request as ready for review August 1, 2022 16:13
@phloux phloux requested review from giomfo and yostyle August 1, 2022 16:13
@giomfo giomfo self-assigned this Aug 1, 2022
giomfo
giomfo approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phloux phloux merged commit 8780182 into develop Aug 2, 2022
@phloux phloux deleted the phlpro/643-remove-flags branch August 2, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giomfo giomfo giomfo approved these changes

@yostyle yostyle Awaiting requested review from yostyle

Assignees

@giomfo giomfo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phloux @giomfo