[Left panel] add an option "Inviter à rejoindre Tchap" (#449) #506
Conversation
There was a problem hiding this comment.
Tests to invite a new contact by email are ok
But the cleaning in ContactsViewController has been to strong, it broke the possibility to invite someone by email in an existing room (see my comments, we would have to keep more code until we switch to the Element contacts picker
| self.sideMenuNavigationViewController.dismiss(animated: true) { | ||
| self.delegate?.sideMenuCoordinator(self, didTapMenuItem: menuItem, fromSourceView: sourceView) | ||
| } | ||
| break |
There was a problem hiding this comment.
I'm not sure break is useful here in swift
| -(BOOL)isInviteByLinkButtonIndexPath:(NSIndexPath*)indexPath | ||
| { | ||
| return (indexPath.section == inviteByLinkButtonSection); | ||
| } | ||
|
|
||
| -(BOOL)isAddEmailButtonIndexPath:(NSIndexPath*)indexPath |
There was a problem hiding this comment.
@phlniji we have to keep this code to be able to invite by email in an existing room
| @@ -482,16 +350,6 @@ - (void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath | |||
| return; | |||
| } | |||
|
|
|||
| // Check whether the user wants to add manually some email into the list | |||
| if ([self.contactsDataSource isAddEmailButtonIndexPath:indexPath]) | |||
There was a problem hiding this comment.
@phlniji we have to keep this code to be able to invite by email in an existing room (until we switch to the Element-ios contacts picker)
This button is
| @@ -1216,21 +1216,11 @@ - (BOOL)tableView:(UITableView *)tableView canEditRowAtIndexPath:(NSIndexPath *) | |||
|
|
|||
| #pragma mark - | |||
|
|
|||
| -(BOOL)isInviteButtonIndexPath:(NSIndexPath*)indexPath | |||
There was a problem hiding this comment.
You have to remove this method in ContactsDataSource.h too
#449