Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mainlining] Update account_validity requests #718

Closed
giomfo opened this issue Jan 24, 2023 · 3 comments · Fixed by #755
Closed

[Mainlining] Update account_validity requests #718

giomfo opened this issue Jan 24, 2023 · 3 comments · Fixed by #755
Assignees
Labels

Comments

@giomfo
Copy link
Contributor

giomfo commented Jan 24, 2023

During the mainlining of synapse, a new optional module has been introduced to handle the account validity.
This involves a new path for the account_validity requests:
/_matrix/client/unstable/account_validity/* is replaced by /_synapse/client/email_account_validity/*
The request format does not change

For the moment the new module has not been deployed

This path is used client side to request a new email or submit a token (send_mail and renew)
I don't think we are using the /renew API

1- Check the occurrences of the AccountValidityAPI use
2- Sync with Ops to set up the account_validity module on DEV platform
3- Update the service to use/test the new path on DEV platform
4- Sync with the Web, Mobile and Ops teams to define a plan to update Tchap clients and the Prod/Preprod infra

@giomfo giomfo added the iOS label Jan 24, 2023
@phloux phloux self-assigned this Jan 25, 2023
@NicolasBuquet
Copy link
Contributor

The only place account_validity API path is used on iOS side is in AccountValidityService class (in Managers) in public method requestRenewalEmail(completion: @escaping (MXResponse<Void>) -> Void) -> MXHTTPOperation?.

This method is only called in AppCoordinator class (in Riot/Modules/Application) to request the sending of a new email with activation link in case the current account is expired.

@NicolasBuquet
Copy link
Contributor

See Android issue : tchapgouv/tchap-android#846

@NicolasBuquet
Copy link
Contributor

Done as in Android.

@NicolasBuquet NicolasBuquet linked a pull request Feb 16, 2023 that will close this issue
@NicolasBuquet NicolasBuquet self-assigned this Apr 11, 2023
NicolasBuquet added a commit that referenced this issue Apr 17, 2023
…validity-requests

 [Mainlining] Update account_validity requests #718
NicolasBuquet added a commit that referenced this issue Apr 17, 2023
…validity-requests

 [Mainlining] Update account_validity requests #718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants