Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings] Move back to Element settings screen #576

Closed
giomfo opened this issue Jun 17, 2022 · 3 comments
Closed

[Settings] Move back to Element settings screen #576

giomfo opened this issue Jun 17, 2022 · 3 comments
Assignees
Labels

Comments

@giomfo
Copy link
Contributor

giomfo commented Jun 17, 2022

Currently we are using a specific Tchap settings screen based on Riot-iOs settings

We want here to update Tchap-iOS settings screen by using the most recent Element-iOS screen.
I will share here several screenshots (left: Element, right: Tchap), by marking :

  • in red what we want to hide from Element-iOS
  • in green what we want to keep from Tchap-iOS

tchap-settings

I will detail here the change password point: We improve in Tchap the change password flow : alert the end user about the potential loss of history + support Apple strong password service. We will have to keep this new flow. We will have to apply this change in Element-iOS in parallel (an issue should be created for that in Element-iOS).

image

tchap-settings2

tchap-settings3

tchap-settings4

tchap-settings5

@phloux
Copy link

phloux commented Jun 28, 2022

As requested this afternoon by Angelo, we also should move down the "Se déconnecter" button under the "Désactiver mon compte" one.

@giomfo
Copy link
Contributor Author

giomfo commented Jun 28, 2022

As requested this afternoon by Angelo, we also should move down the "Se déconnecter" button under the "Désactiver mon compte" one.

@areox-net, can you please create an issue in Element-iOS to present your request, I will then submit it to the designers who may agree to change this in Element-iOS. My plan is to limit customisation in these settings. We already have to manage the existing differences
@phlniji cc

@areox-net
Copy link
Collaborator

@giomfo Here is the issue in Element-iOS element-hq/element-ios#6362

phloux pushed a commit that referenced this issue Jul 26, 2022
[Settings] Move back to Element settings screen #576
@giomfo giomfo closed this as completed Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants