Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Public rooms] - List all the forums from the rooms directory #152

Merged
merged 2 commits into from
Aug 2, 2021
Merged

[Public rooms] - List all the forums from the rooms directory #152

merged 2 commits into from
Aug 2, 2021

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Jul 30, 2021

@yostyle yostyle requested review from giomfo and Florian14 July 30, 2021 14:34
giomfo
giomfo approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one comment

vector/src/main/java/im/vector/app/features/roomdirectory/PublicRoomsViewState.kt Outdated
// Set of joined roomId,
val joinedRoomsIds: Set<String> = emptySet(),
// keys are room alias or roomId
val changeMembershipStates: Map<String, ChangeMembershipState> = emptyMap(),
val roomDirectoryData: RoomDirectoryData = RoomDirectoryData()
val roomDirectoryData: RoomDirectoryData = RoomDirectoryData(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you think we should remove this field to clean up the state?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I hesitated to do that. Applied

@yostyle yostyle merged commit 82854c6 into develop Aug 2, 2021
@yostyle yostyle deleted the yostyle/forum branch August 2, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giomfo giomfo giomfo approved these changes

@Florian14 Florian14 Awaiting requested review from Florian14

Assignees

@giomfo giomfo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yostyle @giomfo