Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Travis to check for changes after regenerating tests #965

Merged
merged 2 commits into from
Apr 11, 2017

Conversation

leobalter
Copy link
Member

No description provided.

@leobalter leobalter requested a review from gnarf April 11, 2017 17:02
@leobalter leobalter changed the title Update Travis to check for changes after regenerating tests [WIP] Update Travis to check for changes after regenerating tests Apr 11, 2017
@leobalter leobalter changed the title [WIP] Update Travis to check for changes after regenerating tests Update Travis to check for changes after regenerating tests Apr 11, 2017
@leobalter
Copy link
Member Author

Thanks, @tcare!

@leobalter leobalter merged commit 4dbd704 into tc39:master Apr 11, 2017
@leobalter leobalter deleted the travis-prs branch April 11, 2017 17:09
@jugglinmike
Copy link
Contributor

Unless I am mistaken, this change was made with the expectation that
contributors manually generate tests and submit them as part of the review
process. This is not what I had in mind with gh-546. There, I proposed
deployment logic (which has since been moved to a separate
script
)
that would result in the automated introduction of generated files. Note that
the current contribution guidelines read:

Tests expressed with this convention are built automatically following the
source files' acceptance into the project. Patches should not include
assets built from these sources.

So if we want to continue to require contributors to submit
procedurally-generated files, we'll need to change that text (in addition to
removing the deployment logic/key).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants