Reduce reliance on fnGlobalObject.js
#595
Conversation
This harness function is not necessary in the majority of cases in which it is used. Remove its usage to simplify tests and decrease the amount of domain-specific knowledge necessary to contribute to the test suite. Persist the harness function itself for use by future tests for ES2015 modules (such a helper is necessary for tests that are interpreted as module code).
| ---*/ | ||
|
|
||
| assert.sameValue(Array.isArray(fnGlobalObject()), false, 'Array.isArray(fnGlobalObject())'); | ||
| assert.sameValue(Array.isArray(this), false, 'Array.isArray(fnGlobalObject())'); |
There was a problem hiding this comment.
the assertion message still has the old method
There was a problem hiding this comment.
Whoops! I'll update all three assertion messages
|
a few comments above, the current tests are looking good. we can delete There are some cases declaring a There are some other tests requiring some updates for good. Once again, not in this PR. See #595 (diff) |
I'd rather not--the utility function is still useful for module code, where I agree that it would be good to clean these tests up, and also that it is Thanks for the review! |
That's right, I forgot about it.
My bad I started the code review minutes after I opened this PR (locally first). This message is great. |
|
LGTM |
|
Merged as 7f88f29. |
This harness function is not necessary in the majority of cases in which
it is used. Remove its usage to simplify tests and decrease the amount
of domain-specific knowledge necessary to contribute to the test suite.
Persist the harness function itself for use by future tests for ES2015
modules (such a helper is necessary for tests that are interpreted as
module code).
This resolves gh-568