Add System.global tests
#567
Conversation
| // Copyright (C) 2016 Jordan Harband. All rights reserved. | ||
| // This code is governed by the BSD license found in the LICENSE file. | ||
| /*--- | ||
| esid: system |
There was a problem hiding this comment.
I believe this should be esid: sec-system or if the id is not defined yet we can use esid: pending.
|
@jugglinmike thanks, definitely some form of interest :-) Any changes I need to make on this PR specifically? :-D |
|
Nope, this all looks good to me! If I learn something new about |
ljharb
force-pushed
the
system_global
branch
2 times, most recently
from
7379a5e to
b6cf999
Compare
|
Merged at 45e5fc8. First time I used Github's squash and merge button, and it worked just fine! 👍 |
|
Thanks! |
|
I thought TC39's policy was to wait for Stage 3 before merging test262 tests. This proposal is still at Stage 2. Why was it merged? Maybe it should be backed out for now until it reaches Stage 3. |
This reverts commit 45e5fc8.
|
My bad. I'm reverting this and setting a PR to re-add when it's ok. |
|
@littledan there's no policy that things must not be merged before stage 3 - only that they must be merged in stage 3. That said, I'm fine with a revert if you think that's important. |
|
@ljharb Spec changes aren't quite stable yet in Stage 2, so we don't accept tests before Stage 3. |
|
Thanks @leobalter for reverting the tests by the way. |
Closes tc39#605, relates to tc39#567 / tc39/proposal-global#12 / bocoup@9c45e2a
|
This has now been preempted by #765. |
Closes #605, relates to #567 / tc39/proposal-global#12 / bocoup@9c45e2a
(tc39/proposal-global#12)
Since this proposal is stage 2, it's OK to hold off on merging these tests - I will seek stage 3 in May after which it would be ideal to have them merged :-)