Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that async iterator methods don't pass absent values #2551

Merged
merged 3 commits into from
Mar 30, 2020

Conversation

shvaikalesh
Copy link
Member

@rwaldron
Copy link
Contributor

@leobalter would you be available for a review?

ljharb
ljharb previously approved these changes Mar 29, 2020
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests LGTM

@shvaikalesh shvaikalesh force-pushed the async-iterator-not-pass-undefined branch from b68d087 to 80a9c97 Compare March 30, 2020 18:44
@shvaikalesh
Copy link
Member Author

shvaikalesh commented Mar 30, 2020

Directories and front matters for throw and return tests were mixed up, now fixed.

@rwaldron rwaldron merged commit b90a11e into tc39:master Mar 30, 2020
@iamstolis
Copy link
Contributor

These tests assume that syncIterator.next/return/throw() is called without argument when the corresponding method of asyncIterator is called without argument. I believe that this is a wrong assumption. The tests are using YieldExpression : yield * AssignmentExpression. The runtime semantics of this construction says that received.[[Value]] is passed to next/return/throw unconditionally there. This is not affected by the normative change these tests attempt to verify. In other words, it seems that these tests are incorrect. Am I missing anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants