Merge pull request #1587 from peterwmwong/update-matchall

Update tests for String.prototype.matchAll
tc39 · Jun 8, 2018 · f90a52b · f90a52b
2 parents bb24a39 + bbad948
commit f90a52b
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 72 deletions.
diff --git a/test/built-ins/RegExp/prototype/Symbol.matchAll/internal-regexp-lastindex-not-zero.js b/test/built-ins/RegExp/prototype/Symbol.matchAll/internal-regexp-lastindex-not-zero.js
diff --git a/...hAll/isregexp-internal-regexp-is-false.js → ...e/Symbol.matchAll/isregexp-called-once.js b/...hAll/isregexp-internal-regexp-is-false.js → ...e/Symbol.matchAll/isregexp-called-once.js
@@ -2,7 +2,7 @@
 // This code is governed by the BSD license found in the LICENSE file.
 /*---
 esid: pending
-description: Throws TypeError when internally created RegExp's @@match is false
+description: IsRegExp should only be called once
 info: |
   RegExp.prototype [ @@matchAll ] ( string )
     [...]
@@ -13,17 +13,28 @@ info: |
     2. If ? IsRegExp(R) is true, then
       [...]
     3. Else,
-      a. Let matcher be RegExpCreate(R, "g").
-      b. If ? IsRegExp(matcher) is not true, throw a TypeError exception.
+      a. Let flags be "g".
+      b. Let matcher be ? RegExpCreate(R, flags).
 features: [Symbol.match, Symbol.matchAll]
 ---*/
 
+var internalCount = 0;
 Object.defineProperty(RegExp.prototype, Symbol.match, {
-  get() {
-    return false;
+  get: function() {
+    ++internalCount;
+    return true;
   }
 });
 
-assert.throws(TypeError, function() {
-  RegExp.prototype[Symbol.matchAll].call({}, '');
-});
+var count = 0;
+var o = {
+  get [Symbol.match]() {
+    ++count;
+    return false;
+  }
+};
+
+RegExp.prototype[Symbol.matchAll].call(o, '1');
+
+assert.sameValue(0, internalCount);
+assert.sameValue(1, count);
diff --git a/test/built-ins/RegExp/prototype/Symbol.matchAll/isregexp-internal-regexp-throws.js b/test/built-ins/RegExp/prototype/Symbol.matchAll/isregexp-internal-regexp-throws.js
diff --git a/test/built-ins/RegExp/prototype/Symbol.matchAll/regexpcreate-this-throws.js b/test/built-ins/RegExp/prototype/Symbol.matchAll/regexpcreate-this-throws.js
@@ -13,7 +13,8 @@ info: |
     2. If ? IsRegExp(R) is true, then
       [...]
     3. Else,
-      a. Let R be RegExpCreate(R, "g").
+      a. Let flags be "g".
+      b. Let matcher be ? RegExpCreate(R, flags).
 features: [Symbol.matchAll]
 ---*/
 

diff --git a/test/built-ins/Symbol/matchAll/prop-desc.js b/test/built-ins/Symbol/matchAll/prop-desc.js
@@ -8,7 +8,7 @@ info: |
     This property has the attributes { [[Writable]]: false, [[Enumerable]]:
     false, [[Configurable]]: false }.
 includes: [propertyHelper.js]
-features: [Symbol.match]
+features: [Symbol.matchAll]
 ---*/
 
 assert.sameValue(typeof Symbol.matchAll, 'symbol');