Format spec text with ecmarkup formatter #2937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can no longer throw, but we didn't notice that because of a bug in ecmarkup (tc39/ecmarkup#609). Change the return type, adjust the call sites not to unwrap the completion, and work around the ecmarkup bug with an editor's note and by putting the offending line in backticks so that ecmarkup doesn't consider it semantically.
Based on the one in ecma262, but use the same method of installing Node that we use in the other workflows.
ptomato
force-pushed
the
2623-emu-format
branch
from
11ba1e3 to
7490735
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to break up the huge diff by grouping it into logical changes that should be easy to scan.
There is one actual change here. Running the formatter led me to discover a bug in ecmarkup which had prevented the linter from noticing that FormatDateTimePattern should no longer return a completion record.
Closes: #2623