Add spec text #11
Add spec text #11
Conversation
There was a problem hiding this comment.
This is a good basis, but some changes are needed, mostly described through inline comments.
In general, don't check in the spec text; that's difficult to maintain. Instead, use gh-actions or another CI system to automatically build it, as other repos do. (However, this is some work and could be done in follow-on patch.)
This initial spec text touches on two of the big design questions that we've been discussing:
- Do we balance in Intl.DurationFormat, or leave that logic entirely to Temporal? (This text says, leave to Temporal, as I thought was our initial answer)
- Do we ask constructors to list fields explicitly, or have higher-level upper/lower logic? (This text says, explicitly, but I thought our plan was to start with smallestField/largestField)
Probably the spec text here should be based on smallestField/largestField, which would mean adding some more logic for that. The logic here might be a little subtle, which is why I like having spec text written out, as a design tool for talking through these cases.
There was a problem hiding this comment.
The main thing is improving the logic around dotted. We have to explain how to resolve from the fields to the dotted pattern, including handling cases where there's no dotted pattern for the field set provided.
Overall, I think we have things concrete enough for Stage 2, and this patch can land as is, with future fixes in follow-ons. Getting a concrete spec has helped us get a first draft semantics and enumerate the issues to solve, as it should at this stage.
| 1. Append _patternPart_ to the end of _result_. | ||
| 1. Else if _duration_[[<_p_>]] is not *undefined* and _p_ exists in _durationFormat_.[[Fields]], then | ||
| 1. Let _num_ be FormatNumeric(_durationFormat_.[[NumberFormat]], _duration_[[<_p_>]]). | ||
| 1. Append the new Record { [[Type]]: _p_, [[Value]]: _num_ } to the end of _result_. |
There was a problem hiding this comment.
I think we should include the individual numeric parts here, not just lump it all together. You can do this by calling PartitionNumberPattern rather than FormatNumeric, as RelativeTimeFormat does.
/cc @younies @sffc @littledan