Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dead assign in FormatNumericUnits when secondsFormatted is true #222

Closed
anba opened this issue Nov 7, 2024 · 0 comments · Fixed by #224
Closed

Dead assign in FormatNumericUnits when secondsFormatted is true #222

anba opened this issue Nov 7, 2024 · 0 comments · Fixed by #224

Comments

@anba
Copy link
Contributor

anba commented Nov 7, 2024

FormatNumericUnits, step 18.b can be removed:

Set signDisplayed to false.
ben-allen added a commit to ben-allen/proposal-intl-duration-format that referenced this issue Nov 8, 2024
@ben-allen
Editorial: Remove unnecessary Set _signDisplayed_ to false step
2e20e12 
after call to `FormatNumericSeconds` in `FormatNumericUnits`.

Resolves issue tc39#222
@ben-allen ben-allen mentioned this issue Nov 8, 2024
Merged
ben-allen added a commit to ben-allen/proposal-intl-duration-format that referenced this issue Nov 8, 2024
@ben-allen
Editorial: Remove unnecessary Set _signDisplayed_ to false step
e1a63d6 
after call to `FormatNumericSeconds` in `FormatNumericUnits`.

Resolves issue tc39#222
ben-allen added a commit to ben-allen/proposal-intl-duration-format that referenced this issue Nov 13, 2024
@ben-allen
Editorial: Remove unnecessary Set _signDisplayed_ to false step
d80b2b4 
after call to `FormatNumericSeconds` in `FormatNumericUnits`.

Resolves issue tc39#222
ben-allen added a commit that referenced this issue Nov 13, 2024
@ben-allen
Editorial: Remove unnecessary Set _signDisplayed_ to false step
94552b9 
after call to `FormatNumericSeconds` in `FormatNumericUnits`.

Resolves issue #222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@anba