Streamline DisposableStack.prototype.use #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A preview of this PR can be found at https://tc39.es/proposal-explicit-resource-management/pr/143. |
rbuckton
force-pushed
the
streamline-AddDisposableResource
branch
from
adae8df to
0bb8232
Compare
|
NOTE: This is mainly editorial cleanup and does not affect the intended semantics as the spec internal comparisons to |
rbuckton
force-pushed
the
streamline-AddDisposableResource
branch
from
0bb8232 to
8b001f6
Compare
|
I believe this should have no differences in observable semantics, but would appreciate a review to verify. |
|
@tc39/ecma262-editors can you review this change? |
bakkot
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies
DisposableStack.prototype.useto use the existing logic inAddDisposableResourcehandle retrieving theSymbol.disposemethod. This is pretty much the same change I made in https://tc39.es/proposal-async-explicit-resource-management/#sec-disposablestack.prototype.use.