Revert #20 and do not await async inputs’ values without mapping ƒ #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
reviewed
Jul 12, 2022
bakkot
reviewed
Jul 12, 2022
spec.html
Outdated
| @@ -74,10 +74,10 @@ <h1><ins>Array.fromAsync ( _asyncItems_ [ , _mapfn_ [ , _thisArg_ ] ] )</ins></h | |||
| 1. If _mapping_ is *true*, then | |||
| 1. Let _mappedValue_ be Call(_mapfn_, _thisArg_, « _nextValue_, 𝔽(_k_) »). | |||
| 1. IfAbruptCloseAsyncIterator(_iteratorRecord_, _mappedValue_). | |||
| 1. Set _mappedValue_ to Await(_mappedValue_). | |||
| 1. IfAbruptCloseAsyncIterator(_iteratorRecord_, _mappedValue_). | |||
| 1. Set _mappedValue_ to _mappedValue_.[[Value]]. | |||
There was a problem hiding this comment.
IfAbruptCloseAsyncIterator already does this. (It's a macro.)
There was a problem hiding this comment.
Just to be clear, is the suggestion to remove all three of the highlighted lines? I’m rechecking the definition of IfAbruptCloseAsyncIterator, and it does seem to take care of unwrapping mappedValue into its [[Value]]—but I don’t see where it Awaits mappedValue beforehand.
There was a problem hiding this comment.
Just the Set _mappedValue_ to _mappedValue_.[[Value]] line specifically, sorry.
bakkot
approved these changes
Jul 12, 2022
Co-authored-by: Kevin Gibbons <[email protected]>
IfAbruptCloseIterator already takes care of this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #19.
See #19 (comment).
The intent is to match the behavior of
for awaitand iterator-helpers’AsyncIterator.prototype.toArray.