lint against non-kebab-cased enum values #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
force-pushed
the
lint-kebab-enums
branch
from
ae0445d to
e69e569
Compare
src/lint/rules/enum-casing.ts
Outdated
| continue; | ||
| } | ||
| const text = item.contents[0]; | ||
| if (/[A-Z ]/.test(text.contents)) { |
There was a problem hiding this comment.
Suggested change
| if (/[A-Z ]/.test(text.contents)) { | |
| if (!/^[\p{Ll}\d]+(?:-[\p{Ll}\d]+)*$/v.test(text.contents)) { |
src/lint/rules/enum-casing.ts
Outdated
| const location = offsetToLineAndColumn(algorithmSource, text.location.start.offset); | ||
| report({ | ||
| ruleId, | ||
| message: 'enum values should be kebab-cased', |
There was a problem hiding this comment.
Suggested change
| message: 'enum values should be kebab-cased', | |
| message: 'enum values should be lowercase and kebab-cased', |
There was a problem hiding this comment.
Wait what? Doesn't kebab-case imply lowercase?
michaelficarra
approved these changes
Aug 30, 2023
bakkot
force-pushed
the
lint-kebab-enums
branch
from
ea96684 to
0101fc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #544.