Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcuts help dialog #400

Merged
merged 4 commits into from
Jan 6, 2022
Merged

Add shortcuts help dialog #400

merged 4 commits into from
Jan 6, 2022

Conversation

syg
Copy link
Contributor

@syg syg commented Jan 6, 2022

Screenshot from 2022-01-05 16-58-44

@syg syg requested a review from bakkot January 6, 2022 00:59
@syg
Copy link
Contributor Author

syg commented Jan 6, 2022

@bakkot The multipage baseline is failing in a way I don't quite understand. Maybe this shortcuts div needs to be inserted elsewhere?

@bakkot
Copy link
Contributor

bakkot commented Jan 6, 2022

Running npm run update-baselines should fix baselines.

@syg
Copy link
Contributor Author

syg commented Jan 6, 2022

Running npm run update-baselines should fix baselines.

Sorry, I meant update-baselines on multipage is failing in a way I don't understand:


  1) baselines
       test/baselines/sources/multipage.html:
     Error: non-clause children are not yet implemented: DIV
      at Spec.<anonymous> (lib/Spec.js:615:31)
      at Generator.next (<anonymous>)
      at /usr/local/google/home/syg/tc39/ecmarkup/lib/Spec.js:8:71
      at new Promise (<anonymous>)
      at __awaiter (lib/Spec.js:4:12)
      at Spec.buildMultipage (lib/Spec.js:559:16)
      at Spec.<anonymous> (lib/Spec.js:385:28)
      at Generator.next (<anonymous>)
      at fulfilled (lib/Spec.js:5:58)

@bakkot
Copy link
Contributor

bakkot commented Jan 6, 2022

Sorry, I meant update-baselines on multipage is failing in a way I don't understand:

Ah. It's complaining because it sees the div as being basically a top-level clause, since it's at the top level and comes after the intro, and it doesn't know how to split that into a page.

Presumably we want this to be on every page of the multipage build, like the table of contents and unlike the rest of the boilerplate. So, easiest fix is to move this out of buildBoilerplate and into its own step of build, and then to add it to the tocEles list passed to buildMultipage so that it gets cloned onto every page like the table of contents does (which should at that point get renamed to something like sharedEles).

@syg
Copy link
Contributor Author

syg commented Jan 6, 2022

Presumably we want this to be on every page of the multipage build, like the table of contents and unlike the rest of the boilerplate. So, easiest fix is to move this out of buildBoilerplate and into its own step of build, and then to add it to the tocEles list passed to buildMultipage so that it gets cloned onto every page like the table of contents does (which should at that point get renamed to something like sharedEles).

Perfect, thanks for the help.

@bakkot
Copy link
Contributor

bakkot commented Jan 6, 2022

Ah jeeze, now it's failing because of a baseline-like test that isn't a baseline. I can push up a fix for that one.

Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@bakkot bakkot merged commit b971460 into tc39:main Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants