Ensure emu-meta tags are fenced by the same mechanisms that xrefs are #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary so that we can read the clause name while building the body, which we do to determine if it's static semantics. We can't do it when entering the clause itself because we need to build the header element first.
bakkot
force-pushed
the
fix-effect-prop
branch
from
b473f8d to
23de0ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously emu-meta effects propagated through fences.
Note that the first commit is just moving when stuff happens, and has no effect on its own. It should probably be reviewed separately from the third commit, which has the actual changes.