expr-parser: "for some" counts as a declaration (#496)

tc39 · Oct 20, 2022 · dddd539 · dddd539
1 parent b763a69
commit dddd539
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/lint/rules/variable-use-def.ts b/src/lint/rules/variable-use-def.ts
@@ -257,7 +257,8 @@ function walkAlgorithm(steps: OrderedListNode | UnorderedListNode, scope: Scope,
         const prev = parts[i - 1];
         if (
           prev.name === 'text' &&
-          /\b(?:for any |there exists |there is |there does not exist )(\w+ )*$/.test(prev.contents)
+          // prettier-ignore
+          /\b(?:for any |for some |there exists |there is |there does not exist )(\w+ )*$/.test(prev.contents)
         ) {
           scope.declare(varName, part);
           declaredThisLine.add(part);

diff --git a/test/lint-variable-use-def.js b/test/lint-variable-use-def.js
@@ -368,6 +368,17 @@ describe('variables are declared and used appropriately', () => {
       );
     });
 
+    it('"for some" counts as a declaration"', async () => {
+      await assertLintFree(
+        `
+          <emu-alg>
+            1. If some property of _i_ holds for some integer _i_ in the interval from 0 to 10, return _i_.
+            1. Return -1.
+          </emu-alg>
+        `
+      );
+    });
+
     it('declarations from explicit attributes are visible', async () => {
       await assertLintFree(
         `