lint against non-kebab-cased enum values

src/lint/collect-algorithm-diagnostics.ts

@@ -9,6 +9,7 @@ import { warnEmdFailure } from '../utils';
 import lintAlgorithmLineStyle from './rules/algorithm-line-style';
 import lintAlgorithmStepNumbering from './rules/algorithm-step-numbering';
 import lintAlgorithmStepLabels from './rules/algorithm-step-labels';
+import lintEnumCasing from './rules/enum-casing';
 import lintForEachElement from './rules/for-each-element';
 import lintStepAttributes from './rules/step-attributes';
 import lintIfElseConsistency from './rules/if-else-consistency';
@@ -27,6 +28,7 @@ const stepRules: LineRule[] = [
   lintAlgorithmLineStyle,
   lintAlgorithmStepNumbering,
   lintAlgorithmStepLabels,
+  lintEnumCasing,
   lintForEachElement,
   lintStepAttributes,
   lintIfElseConsistency,

src/lint/rules/enum-casing.ts

@@ -0,0 +1,29 @@
+import type { Reporter } from '../algorithm-error-reporter-type';
+import type { OrderedListItemNode } from 'ecmarkdown';
+import { offsetToLineAndColumn } from '../../utils';
+
+const ruleId = 'enum-casing';
+
+/*
+Checks that ~enum-values~ are kebab-cased.
+*/
+export default function (
+  report: Reporter,
+  step: OrderedListItemNode,
+  algorithmSource: string,
+) {
+  for (const item of step.contents) {
+    if (item.name !== 'tilde' || item.contents.length !== 1 || item.contents[0].name !== 'text') {
+      continue;
+    }
+    const text = item.contents[0];
+    if (/[A-Z ]/.test(text.contents)) {
+      const location = offsetToLineAndColumn(algorithmSource, text.location.start.offset);
+      report({
+        ruleId,
+        message: 'enum values should be kebab-cased',
+        ...location,
+      });
+    }
+  }
+}

test/lint-algorithms.js

@@ -438,6 +438,61 @@ describe('linting algorithms', () => {
     });
   });
 
+  describe('kebab-case enums', () => {
+    const ruleId = 'enum-casing';
+    it('rejects various other casings', async () => {
+      await assertLint(
+        positioned`
+        <emu-alg>
+          1. Do something with ~${M}aValue~.
+        </emu-alg>`,
+        {
+          ruleId,
+          nodeType,
+          message: 'enum values should be kebab-cased',
+        }
+      );
+
+      await assertLint(
+        positioned`
+        <emu-alg>
+          1. Do something with ~${M}ADifferentValue~.
+        </emu-alg>`,
+        {
+          ruleId,
+          nodeType,
+          message: 'enum values should be kebab-cased',
+        }
+      );
+
+      await assertLint(
+        positioned`
+        <emu-alg>
+          1. Do something with ~${M}a value with spaces~.
+        </emu-alg>`,
+        {
+          ruleId,
+          nodeType,
+          message: 'enum values should be kebab-cased',
+        }
+      );
+    });
+
+    it('negative', async () => {
+      await assertLintFree(`
+        <emu-alg>
+          1. Do something with ~a-kebab-cased-value~.
+        </emu-alg>
+      `);
+
+      await assertLintFree(`
+        <emu-alg>
+          1. Do something with ~numeric-value-32~.
+        </emu-alg>
+      `);
+    });
+  });
+
   describe('for each element', () => {
     const ruleId = 'for-each-element';
     it('rejects loops without types', async () => {