Editorial: Add 'Position' and 'Original Position' records #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
approved these changes
Apr 7, 2025
takikawa
reviewed
Apr 10, 2025
takikawa
reviewed
Apr 10, 2025
takikawa
approved these changes
Apr 10, 2025
|
I rebased and made the change to "Original Position Record". Maybe have one last look if the rebase was done correctly before merging (fixed a warning about a trailing space as a drive-by). Thanks! |
nicolo-ribaudo
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the 'Position' record consisting of a line plus column and a 'Original Position' record, consisting of a source index, line and column.
The mapping record thus changes to contain one generated position record and one original position record. This makes the intention of a mapping a bit more clear in the spec: e.g. a [[OriginalLine]] that is null while [[OriginalColumn]] is present, does not make a lot of sense (while possible to achieve in the encoding).
The PR also provides a general comparison function and replaces the adhoc "LessThan" mapping comparison in the index decoding algorithm.
We'll also use the 'Position' record in the spec text of the "scopes" proposal.
Preview: https://tc39.es/ecma426/pr/194/