Normative: Intl.RelativeTimeFormat.supportedLocalesOf.length should be manually specified to be 1 #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add text about the length property of supportedLocalesOf in RelativeTimeFormat to make it consistent with other parts.
ryzokuken
approved these changes
May 26, 2020
|
@leobalter @gibson042 TC39 reach consensus this morning. Could you approve this PR now? |
leobalter
approved these changes
Jun 1, 2020
sffc
changed the title
jswalden
changed the title
|
@FrankYFTang there are no tests for this (see: tc39/test262#2861). Do you have the bandwidth to work on adding tests? |
Isn't https://github.com/tc39/test262/blob/main/test/intl402/RelativeTimeFormat/constructor/supportedLocalesOf/length.js already cover the testing? |
|
@FrankYFTang yes, I never saw a reference to that test so far. I will update the wiki. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add text about the length property of supportedLocalesOf in RelativeTimeFormat to make it consistent with other parts.
Ref
https://tc39.es/ecma402/#sec-intl.collator.supportedlocalesof
https://tc39.es/ecma402/#sec-intl.numberformat.supportedlocalesof
https://tc39.es/ecma402/#sec-intl.datetimeformat.supportedlocalesof
https://tc39.es/ecma402/#sec-intl.pluralrules.supportedlocalesof
https://tc39.es/ecma402/#sec-Intl.RelativeTimeFormat.supportedLocalesOf