Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Update spec text to be more consistent across interfaces #386

Merged
merged 4 commits into from
Nov 20, 2019

Conversation

gibson042
Copy link
Contributor

No description provided.

Copy link
Member

@leobalter leobalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love these changes, thanks! Consistency ftw!

@leobalter leobalter merged commit 7a8dae1 into tc39:master Nov 20, 2019
@anba
Copy link
Contributor

anba commented Nov 20, 2019

I think ECMA-262 normally uses "Thing instances are ordinary objects that inherit properties from ...", so this sentence should be left as-is:

Intl.Collator instances are ordinary objects that inherit properties from %CollatorPrototype%.

And instead the remaining sections should be updated to include "are ordinary objects".

@leobalter
Copy link
Member

That's accurate and I skipped this one, fixing it in a moment

leobalter added a commit to leobalter/ecma402 that referenced this pull request Nov 20, 2019
Ref tc39#386

The consistency matches the text from ECMA-262
leobalter added a commit that referenced this pull request Nov 20, 2019
Ref #386

The consistency matches the text from ECMA-262
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants