[normative] Limit application of Annex B extension #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that legacy extensions to GlobalDeclarationInstantiation are only observed when the script source is not strict mode code.
|
What legacy extensions are you referring to? What Annex B text are you referring to? I didn't find anything when searching http://www.ecma-international.org/ecma-262/6.0/ for GlobalDeclarationInstantiation. The only uses I found of this name are in section 15.1. |
|
This is a patch for the 2016 revision of the specification, so you'll want to reference that document: |
|
Yes, this seems like a necessary change. Thanks! |
|
Figures: I only added two lines and managed to get a typo into one of them. Thanks for the review! |
|
LGTM, and this'd better be backported to the 2016 draft, right @bterlson? |
bterlson
pushed a commit
that referenced
this pull request
Mar 25, 2016
Ensure that legacy extensions to GlobalDeclarationInstantiation are only observed when the script source is not strict mode code. Fixes #460.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that legacy extensions to GlobalDeclarationInstantiation are only
observed when the script source is not strict mode code.