Meta: changes for printing #3296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Mar 9, 2024
|
This is ready for review now. I ended up not having to change much (or at least not being willing to for now). Just deletes some print styles and fixes a URL so the URL annotation works with it. The formatting check is failing in CI but passing on my machine so I don't know what to do. The message just says something is wrong, but I run the formatter and it's a no-op. |
|
Formatter should get fixed by pulling in tc39/ecmarkup#589. |
syg
approved these changes
Mar 27, 2024
bakkot
approved these changes
Mar 27, 2024
bakkot
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.