Editorial: Narrow return type of GetExportedNames and more assertions #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
approved these changes
Sep 6, 2023
bakkot
approved these changes
Nov 1, 2023
bakkot
added
the
ready to merge
ljharb
changed the title
This makes clear arguments passed to ResolveExport and GetImportedModule is not null.
ljharb
force-pushed
the
module-assertions
branch
from
f93b12a to
ea5ee21
Compare
zhangenming
pushed a commit
to zhangenming/ecma262
that referenced
this pull request
Dec 22, 2023
zhangenming
pushed a commit
to zhangenming/ecma262
that referenced
this pull request
Dec 22, 2023
This makes clear arguments passed to ResolveExport and GetImportedModule is not null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is an exact copy of #3127.
The second commit adds more assertions with respect to Abstract Operations in module section, this was done primarily to make clear non-null values are passed into
ResolveExportandGetImportedModule