Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: combine the two subclauses for HasCallInTailPosition #2896

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Sep 5, 2022

HasCallInTailPosition was defined in one place even prior to the more general SDO consolidation.

But that one place was split up into two subclauses. Prior to SDO consolidation that wasn't remarkable, but afterwards it was, since no other SDO split its parts into subclauses like this. Plus it makes static analysis harder. So remove the subclauses.

I recommend reviewing this PR with whitespace changes suppressed.

@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Oct 19, 2022
@bakkot bakkot force-pushed the combine-has-call-in-tail-position branch from b086396 to f3bc5bc Compare October 20, 2022 01:50
@ljharb ljharb force-pushed the combine-has-call-in-tail-position branch from f3bc5bc to cf1ea07 Compare October 20, 2022 05:20
@ljharb ljharb merged commit cf1ea07 into main Oct 20, 2022
@ljharb ljharb deleted the combine-has-call-in-tail-position branch October 20, 2022 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants