Editorial: combine the two subclauses for HasCallInTailPosition #2896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
force-pushed
the
combine-has-call-in-tail-position
branch
from
fba721f to
b086396
Compare
michaelficarra
approved these changes
Oct 19, 2022
syg
approved these changes
Oct 19, 2022
bakkot
added
the
ready to merge
bakkot
force-pushed
the
combine-has-call-in-tail-position
branch
from
b086396 to
f3bc5bc
Compare
ljharb
force-pushed
the
combine-has-call-in-tail-position
branch
from
f3bc5bc to
cf1ea07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HasCallInTailPosition was defined in one place even prior to the more general SDO consolidation.
But that one place was split up into two subclauses. Prior to SDO consolidation that wasn't remarkable, but afterwards it was, since no other SDO split its parts into subclauses like this. Plus it makes static analysis harder. So remove the subclauses.
I recommend reviewing this PR with whitespace changes suppressed.