Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markup: give math conversion methods AOIDs #2810

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Markup: give math conversion methods AOIDs #2810

merged 2 commits into from
Jul 7, 2022

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Jul 5, 2022

This only affects the published biblio (making these three things be ops instead of terms), which makes it clear they can be invoked. These should always been written this way.

@bakkot bakkot mentioned this pull request Jul 5, 2022
Merged
@bakkot bakkot marked this pull request as draft July 5, 2022 20:17
@bakkot
Copy link
Contributor Author

bakkot commented Jul 5, 2022 •
edited
Loading

Apparently this breaks the links; gotta figure out why. Fixed in the most recent version of ecmarkup, now included in this PR.

@bakkot bakkot mentioned this pull request Jul 6, 2022
Merged
@bakkot bakkot marked this pull request as ready for review July 7, 2022 02:42
@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Jul 7, 2022
@ljharb ljharb added meta markup things that change the spec rendering, but not the contents labels Jul 7, 2022
@ljharb ljharb merged commit 358fcc9 into main Jul 7, 2022
@ljharb ljharb deleted the expr-parser branch July 7, 2022 17:41
@michaelficarra
Copy link
Member

Related: #2786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelficarra michaelficarra michaelficarra approved these changes

Assignees
No one assigned
Labels
markup things that change the spec rendering, but not the contents meta ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bakkot @michaelficarra @ljharb