Normative: ToInteger: fix spec bug from #1827 that allows (-1,0) to produce -0
#1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
added
normative change
ljharb
requested review from
syg,
michaelficarra,
bakkot,
devsnek and
a team
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Feb 15, 2020
…) to produce `-0` (tc39#1871)
ljharb
force-pushed
the
to_integer_spec_bug
branch
from
d4f4652 to
b221da8
Compare
devsnek
reviewed
Feb 15, 2020
bakkot
approved these changes
Feb 15, 2020
There was a problem hiding this comment.
Works for me (with @devsnek's change), though I would phrase it as
1. Let _integer_ be the Number value that is the same sign as _number_ and whose magnitude is floor(abs(_number_)).
1. If _integer_ is *-0*, return *+0*.
1. Return _integer_.
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Feb 15, 2020
…) to produce `-0` (tc39#1871)
ljharb
force-pushed
the
to_integer_spec_bug
branch
from
b221da8 to
b09fb0e
Compare
bakkot
reviewed
Feb 15, 2020
…) to produce `-0` (tc39#1871)
ljharb
force-pushed
the
to_integer_spec_bug
branch
from
b09fb0e to
8e5ae7b
Compare
bakkot
approved these changes
Feb 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #1827 (comment)