Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consistently use either "nonempty" or "non-empty" spelling #2907

Closed
michaelficarra opened this issue Sep 16, 2022 · 3 comments · Fixed by #2910
Closed

consistently use either "nonempty" or "non-empty" spelling #2907

michaelficarra opened this issue Sep 16, 2022 · 3 comments · Fixed by #2910
Labels
editorial change establishes editorial conventions good first issue

Comments

@michaelficarra
Copy link
Member

We use both spellings. We should spell them all the same. I prefer reading the hyphenated one.
@michaelficarra
Copy link
Member Author

We also say "not empty" in places and may want to normalise those as well.

@bakkot
Copy link
Contributor

bakkot commented Sep 16, 2022

We also say "not empty" in places and may want to normalise those as well.

I'd prefer to stick with "If X is not empty" over "If X is non-empty", if those are the places you're thinking of.

@michaelficarra
Copy link
Member Author

Yeah I kinda feel "not empty" is an ephemeral state and "non-empty" is describing an invariant.

michaelficarra added a commit that referenced this issue Sep 19, 2022
@michaelficarra
fixes #2907: replace any occurrences of "nonempty" with "non-empty"
345e9e0
@michaelficarra michaelficarra mentioned this issue Sep 19, 2022
Merged
@ljharb ljharb closed this as completed in e72a6b2 Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editorial change establishes editorial conventions good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editorial: replace any occurrences of "nonempty" with "non-empty" tc39/ecma262
2 participants
@michaelficarra @bakkot