Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music credits for TV series #66

Closed
Tonza opened this issue Sep 15, 2016 · 5 comments
Closed

Music credits for TV series #66

Tonza opened this issue Sep 15, 2016 · 5 comments

Comments

@Tonza
Copy link

Tonza commented Sep 15, 2016

Hello

I'm trying to list music credits for TV series (for example House), but imdbphp returns empty results with composer(). Is there another command for that or is this bug?

@Tonza Tonza changed the title Music credits for series Music credits for TV series Sep 15, 2016
@tboothman
Copy link
Owner

tboothman commented Sep 17, 2016

I'm not really sure what the composer method is meant to do, but the soundtrack credits i.e. http://gb.imdb.com/title/tt0412142/soundtrack?ref_=tt_trv_snd are fetched with Title::soundtrack()

@tboothman
Copy link
Owner

On The Matrix composer() Would get you Don Davis, because he's in the "Music By" section on http://www.imdb.com/title/tt0133093/fullcredits?ref_=tt_cl_sm#cast
There's a "Series Music by" section on http://www.imdb.com/title/tt0412142/fullcredits?ref_=tt_cl_sm#cast so I suppose if it looked for that as well then you'd get Jason Derlatka, Jon Ehrlich, Christopher Hoag, Jeremy Sweet for house. Is that what you'd like it to do?

@Tonza
Copy link
Author

Tonza commented Sep 19, 2016

Yeah, "Series Music by" is not returned with composer() and that is what I would like to get.

@tboothman
Copy link
Owner

Started to implement this and I wonder if "Series Music Department" should be in there too, or that should be the main one?
The Wire http://www.imdb.com/title/tt0306414/fullcredits?ref_=tt_cl_sm#cast has no "Music By" section, but does have a "Series Music Department" which includes whoever did the title.
In House, also, the theme track is only mentioned in the "Series Music Department" section

@Tonza
Copy link
Author

Tonza commented Sep 20, 2016

It seems that in some TV series there is "Series Music Department" (imdb.com/title/?/fullcredits/music_department) and some have "Series Music By" (imdb.com/title/?/fullcredits/composer) and some have both. Neither is returned with composer().

Edit: Game of Thrones for example has both and there is different names in both sections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants